This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
keith gerrit-no-reply at lists.osmocom.orgkeith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/24237 ) Change subject: Implement ICMP response for inactive IP address. ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ggsn/+/24237/1/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/24237/1/ggsn/ggsn.c@614 PS1, Line 614: len = len - 20; > My software security background immediately tells me: pass a value < 20! People complain about PHP, but I think maybe trying to learn from C code examples on the internet is WAY more dangerous. I had a comment in my draft code here: http://git.osmocom.org/osmo-ggsn/tree/ggsn/ggsn.c?h=whyteks/icmp2&id=33680054c374cfac57335b1abe0bf276c3309ce6#n618 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/24237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ia2c708feab14bb4cada00b0a90e0cb56d680d1aa Gerrit-Change-Number: 24237 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Mon, 17 May 2021 16:10:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210517/5785ec83/attachment.htm>