Change in osmo-pcu[master]: RIM: Refactor Rx path to decode stack in proper order

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon May 17 12:21:24 UTC 2021


Hello osmith, Jenkins Builder, laforge, dexter, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/24169

to look at the new patch set (#2).

Change subject: RIM: Refactor Rx path to decode stack in proper order
......................................................................

RIM: Refactor Rx path to decode stack in proper order

Previous implementation of the Rx path was first checking the APP ID
before checking the lower layer (container type), which was confusing
because the information is then not verified in ascending order in the
protocol stack.

Let's instead, first, pass the pdu to the correct container type
handler, and only once there, let each container type handler verify the
available applications.

Change-Id: Ibe017c1a6e789f45d74c4a5f5f4608298c8c9f91
---
M src/gprs_bssgp_rim.c
1 file changed, 47 insertions(+), 63 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/69/24169/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24169
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibe017c1a6e789f45d74c4a5f5f4608298c8c9f91
Gerrit-Change-Number: 24169
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210517/d5876205/attachment.htm>


More information about the gerrit-log mailing list