Change in osmo-pcu[master]: RIM: Refactor Rx path to decode stack in proper order

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon May 17 10:58:04 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/24169 )

Change subject: RIM: Refactor Rx path to decode stack in proper order
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Just some cosmetics, looks good otherwise

https://gerrit.osmocom.org/c/osmo-pcu/+/24169/1/src/gprs_bssgp_rim.c 
File src/gprs_bssgp_rim.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/24169/1/src/gprs_bssgp_rim.c@172 
PS1, Line 172: static int handle_ran_info_request(const struct bssgp_ran_information_pdu *pdu, struct gprs_rlcmac_bts *bts, uint16_t nsei)
(line length)


https://gerrit.osmocom.org/c/osmo-pcu/+/24169/1/src/gprs_bssgp_rim.c@182 
PS1, Line 182: received
Rx and "received" are redundant, same below. maybe fix this while at it?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24169
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibe017c1a6e789f45d74c4a5f5f4608298c8c9f91
Gerrit-Change-Number: 24169
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 17 May 2021 10:58:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210517/d2587502/attachment.htm>


More information about the gerrit-log mailing list