Change in pysim[master]: Add codecs for EF_SPN and GSM strings via construct

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Falkenber9 gerrit-no-reply at lists.osmocom.org
Mon May 10 04:16:12 UTC 2021


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/pysim/+/24180

to look at the new patch set (#2).

Change subject: Add codecs for EF_SPN and GSM strings via construct
......................................................................

Add codecs for EF_SPN and GSM strings via construct

This will replace the hand-crafted codec for EF_SPN
by a struct definition using the construct library.
Old encoders are updated and kept for API compatibility
but are not used internally anymore.

New data structures:
* Rpad(Adapter): Right-padded bytestring (0xff, adjustable)
* GsmStringAdapter(Adapter): Codec for "SMS default 7-bit
	coded alphabet as defined int TS 23.038" using
	the gsm0338 library.
* GsmString(n): Convenient wrapper of both above

Adjustments:
* utils: update+deprecate old dec_spn(), enc_spn()
* remove refs to deprecated functions

Change-Id: Ia1d3a3835933bac0002b7c52511481dd8094b994
---
M contrib/jenkins.sh
M pySim-read.py
M pySim/cards.py
M pySim/construct.py
M pySim/ts_51_011.py
M pySim/utils.py
M requirements.txt
M setup.py
8 files changed, 97 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/80/24180/2
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24180
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia1d3a3835933bac0002b7c52511481dd8094b994
Gerrit-Change-Number: 24180
Gerrit-PatchSet: 2
Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210510/725cd988/attachment.htm>


More information about the gerrit-log mailing list