Change in osmocom-bb[master]: trx_toolkit/data_msg.py: update entries in enum Modulation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat May 8 13:26:30 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24016 )

Change subject: trx_toolkit/data_msg.py: update entries in enum Modulation
......................................................................

trx_toolkit/data_msg.py: update entries in enum Modulation

Change-Id: Ia96b263bbb162b6c40f2cf81616118cc297299a5
Related: OS#4006, SYS#4895
---
M src/target/trx_toolkit/data_msg.py
1 file changed, 7 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

Objections:
  dexter: I would prefer this is not merged as is



diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py
index 5e42964..8257c4d 100644
--- a/src/target/trx_toolkit/data_msg.py
+++ b/src/target/trx_toolkit/data_msg.py
@@ -31,11 +31,13 @@
 
 class Modulation(Enum):
 	""" Modulation types defined in 3GPP TS 45.002 """
-	ModGMSK  = (0b0000, 148)
-	Mod8PSK  = (0b0100, 444)
-	ModAQPSK = (0b0110, 296)
-	Mod16QAM = (0b1000, 592)
-	Mod32QAM = (0b1010, 740)
+	ModGMSK		= (0b0000, 1 * GMSK_BURST_LEN)
+	Mod8PSK		= (0b0100, 3 * GMSK_BURST_LEN)
+	ModGMSK_AB	= (0b0110, 1 * GMSK_BURST_LEN)
+	# ModRFU	= (0b0111, 0) # Reserved for Future Use
+	Mod16QAM	= (0b1000, 4 * GMSK_BURST_LEN)
+	Mod32QAM	= (0b1010, 5 * GMSK_BURST_LEN)
+	ModAQPSK	= (0b1100, 2 * GMSK_BURST_LEN)
 
 	def __init__(self, coding, bl):
 		# Coding in TRXD header

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24016
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia96b263bbb162b6c40f2cf81616118cc297299a5
Gerrit-Change-Number: 24016
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210508/32cb8364/attachment.htm>


More information about the gerrit-log mailing list