This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24143 ) Change subject: send DLCX only once ...................................................................... send DLCX only once If the mgcp_client_fsm gets terminated in ST_DLCX_RESP, it has already sent a DLCX to the MGW. So do not send a second one. I noticed the duplicate DLCX for the same endpoint conn identifier while running TTCN3 tests and watching the network trace of test teardown. Change-Id: I35e415f67946b73c74408afe265618cfe4f72b0b --- M src/libosmo-mgcp-client/mgcp_client_fsm.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libosmo-mgcp-client/mgcp_client_fsm.c b/src/libosmo-mgcp-client/mgcp_client_fsm.c index 83dd2f1..9e4a100 100644 --- a/src/libosmo-mgcp-client/mgcp_client_fsm.c +++ b/src/libosmo-mgcp-client/mgcp_client_fsm.c @@ -521,8 +521,10 @@ /* Should the FSM be terminated while there are still open connections * on the MGW, we send an unconditional DLCX to terminate the * connection. This is not the normal case. The user should always use - * mgcp_conn_delete() to instruct the FSM to perform a graceful exit */ - if (strlen(mgcp_ctx->conn_id)) { + * mgcp_conn_delete() to instruct the FSM to perform a graceful exit. + * If in ST_DLCX_RESP, a DLCX was already sent and we did not get a + * response. No point in sending another one. */ + if (fi->state != ST_DLCX_RESP && strlen(mgcp_ctx->conn_id)) { LOGPFSML(fi, LOGL_NOTICE, "MGW/DLCX: FSM termination with connections still present, sending unconditional DLCX...\n"); msg = make_dlcx_msg(mgcp_ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I35e415f67946b73c74408afe265618cfe4f72b0b Gerrit-Change-Number: 24143 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210508/db1034ba/attachment.htm>