This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods ...................................................................... Patch Set 4: (3 comments) https://gerrit.osmocom.org/c/pysim/+/24012/4/tests/test_files.py File tests/test_files.py: https://gerrit.osmocom.org/c/pysim/+/24012/4/tests/test_files.py@39 PS4, Line 39: print > It's not a good idea to use print() directly in unit tests. […] Ack https://gerrit.osmocom.org/c/pysim/+/24012/4/tests/test_files.py@60 PS4, Line 60: if verbose: > Again, logging.debug() would do this for you. Ack https://gerrit.osmocom.org/c/pysim/+/24012/4/tests/test_files.py@71 PS4, Line 71: testcase.assertEqual(testvec_json, decoded_json) > Not sure if it's a good idea to have the test vectors in JSON and match strings. […] there's pros and cons. As stated in the other comment, I somehow think testing the JSON document is the right thing to do here, not comparing python dicts. But I don't have a very strong opinion about it. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Gerrit-Change-Number: 24012 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 07 May 2021 22:02:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210507/01b9b881/attachment.htm>