This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24006 ) Change subject: ts_51_011: fix encoder of EF_SPN: ...................................................................... ts_51_011: fix encoder of EF_SPN: The encoder for EF_SPN is passing the 'spn' parameter (which is a list) directly to enc_spn without taking it apart first. Change-Id: I0a405793c8909d4279e634b93dcb76e5cb2963f3 Related: OS#4963 --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 4189e6e..dba0369 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -522,7 +522,8 @@ def _decode_hex(self, raw_hex): return {'spn': dec_spn(raw_hex)} def _encode_hex(self, abstract): - return enc_spn(abstract['spn']) + spn = abstract['spn'] + return enc_spn(spn[0], spn[1], spn[2]) # TS 51.011 Section 10.3.13 class EF_CBMI(TransRecEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24006 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0a405793c8909d4279e634b93dcb76e5cb2963f3 Gerrit-Change-Number: 24006 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Falkenber9 <robert.falkenberg at tu-dortmund.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210507/d5360715/attachment.htm>