This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24158 )
Change subject: ModemATCommandLink: improve response time for "+CME ERROR"
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/c/pysim/+/24158/2/pySim/transport/modem_atcmd.py
File pySim/transport/modem_atcmd.py:
https://gerrit.osmocom.org/c/pysim/+/24158/2/pySim/transport/modem_atcmd.py@71
PS2, Line 71: if len(lines) >= 2:
You can actually reduce nesting here by doing:
if len(lines) < 2:
continue
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/24158
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I41af33c1898f5ed3d1c5238e45f956c6ceab2826
Gerrit-Change-Number: 24158
Gerrit-PatchSet: 2
Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 07 May 2021 13:16:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210507/d7cda016/attachment.htm>