This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods ...................................................................... Patch Set 4: > I would be careful with such statements. The point here is that each file class defines _data_, and not code. Then there is a shared function that excudes a common unit test with the data specified in the file-specific class. I am fine with having the test vectors in each class. When I posted my comments it was Patchset 1, and the test logic was defined in CardEF.test_encode_decode() and this is what I was not happy about. Now I see that it has been moved to test_files.py. > At least I know python unittest only in he following way: > * specify _code_ for each class to test > * that test is not with the implementation bu in a separate file ACK. > If you are aware of python unittest implementing a data-driven approach with 'test data within implementation', please show some pointers, thanks. I am taking a look at the new patchset, will post my suggestions in a few minutes. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Gerrit-Change-Number: 24012 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 06 May 2021 19:01:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210506/cdbcc120/attachment.htm>