This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24158 ) Change subject: ModemATCommandLink: improve response time for "+CME ERROR" ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/pysim/+/24158/1/pySim/transport/modem_atcmd.py File pySim/transport/modem_atcmd.py: https://gerrit.osmocom.org/c/pysim/+/24158/1/pySim/transport/modem_atcmd.py@74 PS1, Line 74: debug I would log it as debug for OK but definitely as something higher (error?) when it fails. https://gerrit.osmocom.org/c/pysim/+/24158/1/pySim/transport/modem_atcmd.py@78 PS1, Line 78: debug nothing you touched in your patch, but just noticing this: A timeout should at least be notice/warning, IMHO. It shouldn't be hidden in a debug log. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I41af33c1898f5ed3d1c5238e45f956c6ceab2826 Gerrit-Change-Number: 24158 Gerrit-PatchSet: 1 Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 06 May 2021 16:20:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210506/d141d818/attachment.htm>