This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23919 )
Change subject: common/abis: fix the use of deprecated e1inp_line_get() API
......................................................................
common/abis: fix the use of deprecated e1inp_line_get() API
We need curly braces becausee1inp_line_get2() is basically a macro
that calls OSMO_ASSERT(), which in its turn contains an 'if' stmt.
Change-Id: I41a5fd13a7fa40e16bcf1a8099624b654274cee3
---
M src/common/abis.c
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/src/common/abis.c b/src/common/abis.c
index 5b914c7..be7e906 100644
--- a/src/common/abis.c
+++ b/src/common/abis.c
@@ -281,9 +281,9 @@
bts_dev_info.location2 = model_name;
line = e1inp_line_find(0);
- if (line)
- e1inp_line_get(line); /* We want a new reference for returned line */
- else
+ if (line) {
+ e1inp_line_get2(line, __FILE__); /* We want a new reference for returned line */
+ } else
line = e1inp_line_create(0, "ipa"); /* already comes with a reference */
if (!line)
return NULL;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23919
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I41a5fd13a7fa40e16bcf1a8099624b654274cee3
Gerrit-Change-Number: 23919
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210505/75c5acbe/attachment.htm>