Change in libosmocore[master]: gprs_ns2: sns: fix del bind()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue May 4 13:42:05 UTC 2021


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/24120 )


Change subject: gprs_ns2: sns: fix del bind()
......................................................................

gprs_ns2: sns: fix del bind()

When the bind to be removed was the last entry, it would
remove the wrong SNS bind resulting in use-after-free memory.

Change-Id: I79062d404ebba9d5c8f7f209bebde146fa08c71f
---
M src/gb/gprs_ns2_sns.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/20/24120/1

diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index c6e80af..296a2e7 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -1995,6 +1995,7 @@
 		if (tmp->bind == bind) {
 			llist_del(&tmp->list);
 			found = true;
+			break;
 		}
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I79062d404ebba9d5c8f7f209bebde146fa08c71f
Gerrit-Change-Number: 24120
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210504/7df0994c/attachment.htm>


More information about the gerrit-log mailing list