This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24102 ) Change subject: BER-TLV EF support (command, filesystem, shell) ...................................................................... Patch Set 1: Code-Review-1 (5 comments) https://gerrit.osmocom.org/c/pysim/+/24102/1/pySim/utils.py File pySim/utils.py: https://gerrit.osmocom.org/c/pysim/+/24102/1/pySim/utils.py@96 PS1, Line 96: (dict, bytes) > Tuple[dict, bytes] Done https://gerrit.osmocom.org/c/pysim/+/24102/1/pySim/utils.py@119 PS1, Line 119: (int, bytes) > Tuple[int, bytes] Done https://gerrit.osmocom.org/c/pysim/+/24102/1/pySim/utils.py@145 PS1, Line 145: if length < 0x80: > Looks like both cases: […] actually that's a bug. Length values >= 128 must be encoded as two bytes already. I'll fix it. https://gerrit.osmocom.org/c/pysim/+/24102/1/pySim/utils.py@150 PS1, Line 150: struct.pack('!H', length) > length. […] Ack https://gerrit.osmocom.org/c/pysim/+/24102/1/pySim/utils.py@152 PS1, Line 152: struct.pack('!L', length) > length. […] Ack -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibfcce757dcd477fd0d6857f64fbb4346d6d62e63 Gerrit-Change-Number: 24102 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 03 May 2021 19:52:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210503/6093dd3a/attachment.htm>