Change in pysim[master]: utils: Introduce DataObject representation

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24035 )

Change subject: utils: Introduce DataObject representation
......................................................................


Patch Set 4:

(6 comments)

https://gerrit.osmocom.org/c/pysim/+/24035/2/pySim/utils.py 
File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/24035/2/pySim/utils.py@869 
PS2, Line 869: DataObject
> To be fair I also find this part of the documentation extremely confusing :) I would recommend to re […]
Done


https://gerrit.osmocom.org/c/pysim/+/24035/2/pySim/utils.py@917 
PS2, Line 917:         raise TypeError("The derived classes must defined a from_value() method")
> Let's please use @abc.abstractmethod for that.
Done


https://gerrit.osmocom.org/c/pysim/+/24035/2/pySim/utils.py@921 
PS2, Line 921:         raise TypeError("The derived classes must defined a to_value() method")
> Let's please use @abc.abstractmethod for that.
Done


https://gerrit.osmocom.org/c/pysim/+/24035/2/pySim/utils.py@991 
PS2, Line 991:         for m in self.members:
> Ah, sorry for confusing code snippet in my previous comment. Your snippet should work fine.
Done


https://gerrit.osmocom.org/c/pysim/+/24035/2/pySim/utils.py@1097 
PS2, Line 1097: desc
> Unused?
Done


https://gerrit.osmocom.org/c/pysim/+/24035/2/pySim/utils.py@1097 
PS2, Line 1097: sequence=[])
> Same here.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24035
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iac18e7665481c9323cc7d22a3cd93e3da7869deb
Gerrit-Change-Number: 24035
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 03 May 2021 19:50:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210503/86514429/attachment.htm>