Change in pysim[master]: utils: Introduce CommandSet abstraction

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon May 3 19:49:56 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24036 )

Change subject: utils: Introduce CommandSet abstraction
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/24036/3/pySim/utils.py 
File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/24036/3/pySim/utils.py@1171 
PS3, Line 1171: cla_list
> It's implicitly defined as Optional above (default value is None), but you're referencing it uncondi […]
Done


https://gerrit.osmocom.org/c/pysim/+/24036/3/pySim/utils.py@1201 
PS3, Line 1201:         self.cmds = {}
> Cosmetic (I am ok with the current approach too): […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24036
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I314ff15186dc05778ea12363cac0a310b6c7713c
Gerrit-Change-Number: 24036
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 03 May 2021 19:49:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210503/e7f404c8/attachment.htm>


More information about the gerrit-log mailing list