Change in gr-gsm[master]: grgsm_decode: Print frequency or ARFCN message on stderr

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ptrkrysik gerrit-no-reply at lists.osmocom.org
Mon May 3 10:24:41 UTC 2021


Hello vvvelichkov,

I'd like you to do a code review. Please visit

    https://gerrit.osmocom.org/c/gr-gsm/+/24072

to review the following change.


Change subject: grgsm_decode: Print frequency or ARFCN message on stderr
......................................................................

grgsm_decode: Print frequency or ARFCN message on stderr

For some yet unknown reasons in travis on Debian testing and Kali rolling
the message gets printed after the burst and decode.sh and decrypt.sh
tests fails because of this.

Instead of filtering this messages in the tests I think it is better
such messages to be printed on the standard error output

Change-Id: Ib18be898cac74769cabf1b748e40e21d23f08e98
---
M apps/grgsm_decode
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/72/24072/1

diff --git a/apps/grgsm_decode b/apps/grgsm_decode
index 034014e..d754fc7 100755
--- a/apps/grgsm_decode
+++ b/apps/grgsm_decode
@@ -30,6 +30,7 @@
 import grgsm
 import pmt
 import socket
+import sys
 
 
 class grgsm_decoder(gr.top_block):
@@ -368,7 +369,7 @@
         parser.error("Invalid A5 version\n")
 
     if options.cfile and (options.fc is None and options.arfcn is None):
-        print("You haven't provided a frequency or an ARFCN - working without automatic frequency offset correction.\n")
+        print("You haven't provided a frequency or an ARFCN - working without automatic frequency offset correction.\n", file=sys.stderr)
 
     # handle frequency / arfcn input
     arfcn = None

-- 
To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/24072
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-Change-Id: Ib18be898cac74769cabf1b748e40e21d23f08e98
Gerrit-Change-Number: 24072
Gerrit-PatchSet: 1
Gerrit-Owner: ptrkrysik <ptrkrysik at gmail.com>
Gerrit-Reviewer: vvvelichkov <vvvelichkov at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210503/fae09b4a/attachment.htm>


More information about the gerrit-log mailing list