This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23342 )
Change subject: epc_amarisoft: launch ltesim server when starting
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23342/4/src/osmo_gsm_tester/obj/epc_amarisoft.py
File src/osmo_gsm_tester/obj/epc_amarisoft.py:
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23342/4/src/osmo_gsm_tester/obj/epc_amarisoft.py@123
PS4, Line 123: time.sleep(2)
I would add a function in util.py to check if a give interface exists, and use it here in a wait()
The function can be easily implemented by checking:
fd = open('/sys/class/net/$iface_name/operstate')
return read(fd) == "up"
Feel free to submit this in a follow-up patch.
In any case, let's move the "import time" module to the top of the file, that module is basic/generic enough to have it always loaded.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23342
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Iad081e57e2fd9d3cbc3e59e4f729a4721ad778c9
Gerrit-Change-Number: 23342
Gerrit-PatchSet: 4
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 03 May 2021 10:04:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210503/e1ace664/attachment.htm>