Change in pysim[master]: Speed up AT command interface (~130 times faster)

[Falkenber9]

Falkenber9 has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24034 )

Change subject: Speed up AT command interface (~130 times faster)
......................................................................


Patch Set 3:

(1 comment)

> Patch Set 2: Code-Review+2
> 
> (1 comment)
> 
> Giving CR+2, feel free to re-apply if you will upload a new version addressing my comment.

Thanks for that feedback. Hope its OK now.

https://gerrit.osmocom.org/c/pysim/+/24034/2/pySim/transport/modem_atcmd.py 
File pySim/transport/modem_atcmd.py:

https://gerrit.osmocom.org/c/pysim/+/24034/2/pySim/transport/modem_atcmd.py@123 
PS2, Line 123: 		log.info('Modem at "{}" is ready!'.format(self._device))
> This change looks unrelated. […]
Thanks for that feedback. Hope its OK now.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24034
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I69b1cbc0a20d54791e5800bf27ebafc2c8606d93
Gerrit-Change-Number: 24034
Gerrit-PatchSet: 3
Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 03 May 2021 08:08:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210503/468ff590/attachment.htm>