This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24034 ) Change subject: Improve speed of AT command interface (x134) ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Giving CR+2, feel free to re-apply if you will upload a new version addressing my comment. https://gerrit.osmocom.org/c/pysim/+/24034/2/pySim/transport/modem_atcmd.py File pySim/transport/modem_atcmd.py: https://gerrit.osmocom.org/c/pysim/+/24034/2/pySim/transport/modem_atcmd.py@123 PS2, Line 123: log.info('Modem at "{}" is ready!'.format(self._device)) This change looks unrelated. I would keep this line as it is or rather use lazy format-string evaluation (was not aware of it back then) for logging statements. Can be done in a separate patch :) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I69b1cbc0a20d54791e5800bf27ebafc2c8606d93 Gerrit-Change-Number: 24034 Gerrit-PatchSet: 2 Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sun, 02 May 2021 20:59:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210502/d4ad1abb/attachment.htm>