This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23534 ) Change subject: ts_31_102: do not add empty ShellCommands class. ...................................................................... Patch Set 1: Code-Review+1 it is still useful to be able to add application specific commands. I guess the mistake was to not append those commands but rather overwrite a field that was already specified by the superclass during super.__init__. I think a working example on how to do application specific commands would be a good idea. Not sure if we have any real example of how to do that in the code? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0e67c570fc4f17641d990a9cd239632ecf622de3 Gerrit-Change-Number: 23534 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 29 Mar 2021 20:36:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210329/b16ecadb/attachment.htm>