This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/23516 ) Change subject: ggsn: Reject PDP CTX ACT for static IP addresses ...................................................................... ggsn: Reject PDP CTX ACT for static IP addresses We don't implement handling of static IP addresses for now, let's properly reject those rather than allocating a dynamic address anyway. Change-Id: Iac8868438655fe4e5e07d167d7dbd6273dbb7678 Related: OS#5097 --- M ggsn/ggsn.c 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index 267637d..bde7f4b 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -467,9 +467,13 @@ return 0; } - /* FIXME: we manually force all context requests to dynamic here! */ - if (pdp->eua.l > 2) - pdp->eua.l = 2; + /* FIXME: implement context request for static IP addresses! */ + if (pdp->eua.l > 2) { + LOGPPDP(LOGL_ERROR, pdp, "Static IP addresses not supported: %s\n", + osmo_hexdump(pdp->eua.v, pdp->eua.l)); + gtp_create_context_resp(gsn, pdp, GTPCAUSE_NOT_SUPPORTED); + return 0; + } memcpy(pdp->qos_neg0, pdp->qos_req0, sizeof(pdp->qos_req0)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/23516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iac8868438655fe4e5e07d167d7dbd6273dbb7678 Gerrit-Change-Number: 23516 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210329/49ad6a26/attachment.htm>