This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23360 ) Change subject: fix/refactor neighbor config ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/src/osmo-bsc/neighbor_ident.c File src/osmo-bsc/neighbor_ident.c: https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/src/osmo-bsc/neighbor_ident.c@426 PS2, Line 426: if (local_neighbor) { > AFAIU this will never be false since if resolve_neighbor fails, the pointer is NULL, otherwise it's […] resolve_neighbors() returns either a local_neighbor or remote_neighbors, so it may be NULL. IIUC gcc shouldn't complain because resolve_neighbors() always initializes the pointer? but fine. https://gerrit.osmocom.org/c/osmo-bsc/+/23360/2/src/osmo-bsc/neighbor_ident.c@433 PS2, Line 433: && remote_neighbors.id_discr == CELL_IDENT_WHOLE_GLOBAL_PS) { > I find interesting that you prefer putting the "&&" at the start of the line while I prefer putting […] yes, it's a way of easily reading the logical relation: the && / || is always in the same place right at the start of the line. If it is at the end, the eyes need to scan around for the line ending to find the logical relation. Also when put at the start, the sub-condition indenting comes naturally. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ed992f8bfff888b3933733c0576f92d50f2625b Gerrit-Change-Number: 23360 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 24 Mar 2021 20:14:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210324/adb0dc04/attachment.htm>