This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/23376 ) Change subject: filesystem: fix exception string (fid != name) ...................................................................... filesystem: fix exception string (fid != name) It is better to use the term "fid" instead of "name" when a reserved FID is detected. Change-Id: I054f3b3a156f0164c62610cfde1aec2145c20925 Related: OS#4963 --- M pySim/filesystem.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index ad020af..4c84f66 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -143,7 +143,7 @@ if child.name in CardFile.RESERVED_NAMES: raise ValueError("File name %s is a reserved name" % (child.name)) if child.fid in CardFile.RESERVED_FIDS: - raise ValueError("File fid %s is a reserved name" % (child.fid)) + raise ValueError("File fid %s is a reserved fid" % (child.fid)) if child.fid in self.children: if ignore_existing: return -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I054f3b3a156f0164c62610cfde1aec2145c20925 Gerrit-Change-Number: 23376 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210319/721215ea/attachment.htm>