Change in osmo-bsc[master]: Add vty command for Ericsson RBS2000 sync

[keith]

keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23317 )

Change subject: Add vty command for Ericsson RBS2000 sync
......................................................................


Patch Set 4:

(7 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2//COMMIT_MSG@9 
PS2, Line 9: This commit adds support for Selection of syncronization source
> Well, at the end of line because the phrase ends there, which is of course a common ortographic rule […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/include/osmocom/bsc/bts.h 
File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/include/osmocom/bsc/bts.h@381 
PS2, Line 381: 			int sync_src;
> enum om2k_sync_src sync_src;
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/include/osmocom/bsc/bts.h@381 
PS2, Line 381: int
> please use 'enum om2k_sync_src' as type here.
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c 
File src/osmo-bsc/abis_om2000_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c@495 
PS2, Line 495: if
> else if
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c@495 
PS2, Line 495: 	if (!strcmp(argv[0], "external"))
> VTY internal code is parsing the parameters and making sure whatever is passed to this function is e […]
Ack


https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c@681 
PS2, Line 681: sync_src >= 0
> AFAIU, this condition is always true for both variants? I would just print it unconditionally.
Ack


https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c@681 
PS2, Line 681: 	if (bts->rbs2000.sync_src >= 0) {
> you're (both) right of course - this is a hangover from an earlier draft when this code was in bsc_v […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23317
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia3d1acd6b3442238b35fc911092e12a6ac989adb
Gerrit-Change-Number: 23317
Gerrit-PatchSet: 4
Gerrit-Owner: javi-tic <javi at tic-ac.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 13 Mar 2021 06:53:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210313/4274efc4/attachment.htm>