This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23324 ) Change subject: pcu: Set up PCU TDMA clock by sending initial DATA.ind ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23324/2/pcu/PCUIF_Components.ttcn File pcu/PCUIF_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23324/2/pcu/PCUIF_Components.ttcn@508 PS2, Line 508: start_fn := 0 > What's the purpose of this variable? Why don't you just pass 0 directly, given that it's always 0? To let the reader know the FN passed two times in different places below is the same, and describe is the starting one. This way also can be changed if wanted easily if one wishes to test starting from FN != 0. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00c4dd9133ec9a236bf28fb8cb0afd0615791012 Gerrit-Change-Number: 23324 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Fri, 12 Mar 2021 13:54:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210312/70092517/attachment.htm>