This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/23327 ) Change subject: pySim/utils_test.py: prepare this to be executed on Jenkins ...................................................................... pySim/utils_test.py: prepare this to be executed on Jenkins As it turns out, we had this set of unit tests since 2018, but so far they were not executed during the build verification. Let's fix this: * run unittest in discovery mode for all files in 'tests/' (commented out); * rename this file, so it can be automatically detected and executed; * properly import the API to be tested. Currently 2 out of 16 unit tests are failing, so we need to get them passing first and then uncomment the unittest execution. Change-Id: I4d4facfabc75187acd5238ff4d0f26022bd58f82 --- M contrib/jenkins.sh R tests/test_utils.py 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index bfbf4e0..9b4689d 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -15,6 +15,10 @@ pip install pyyaml pip install cmd2 +# Execute automatically discovered unit tests first +# TODO: uncomment once all tests are passing +# python -m unittest discover -v -s tests/ + cd pysim-testdata ../tests/pysim-test.sh diff --git a/pySim/utils_test.py b/tests/test_utils.py similarity index 97% rename from pySim/utils_test.py rename to tests/test_utils.py index 5cdb55e..44fe631 100644 --- a/pySim/utils_test.py +++ b/tests/test_utils.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 import unittest -import utils +import pySim.utils as utils class DecTestCase(unittest.TestCase): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4d4facfabc75187acd5238ff4d0f26022bd58f82 Gerrit-Change-Number: 23327 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210312/f51fc772/attachment.htm>