Change in osmo-sgsn[master]: Remove bogus DNS log category

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Mar 10 12:30:06 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23248 )

Change subject: Remove bogus DNS log category
......................................................................

Remove bogus DNS log category

When we switched to the libosmogb NS2 implementation, we should have
removed the DNS category, as NS2 uses DLNS internally and hence DNS
is unused.

Change-Id: Ia4723ab344ad6a1927029a2d5d0dda020266b39d
Closes: OS#5058
---
M include/osmocom/sgsn/debug.h
M src/sgsn/sgsn_main.c
M tests/sgsn/sgsn_test.c
3 files changed, 0 insertions(+), 11 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/sgsn/debug.h b/include/osmocom/sgsn/debug.h
index 37e4a09..80c5d9f 100644
--- a/include/osmocom/sgsn/debug.h
+++ b/include/osmocom/sgsn/debug.h
@@ -13,7 +13,6 @@
 	DMEAS,
 	DREF,
 	DGPRS,
-	DNS,
 	DLLC,
 	DSNDCP,
 	DSLHC,
diff --git a/src/sgsn/sgsn_main.c b/src/sgsn/sgsn_main.c
index 2cabbf3..97309dd 100644
--- a/src/sgsn/sgsn_main.c
+++ b/src/sgsn/sgsn_main.c
@@ -310,11 +310,6 @@
 		.description = "GPRS Packet Service",
 		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
-	[DNS] = {
-		.name = "DNS",
-		.description = "GPRS Network Service (NS)",
-		.enabled = 1, .loglevel = LOGL_NOTICE,
-	},
 	[DLLC] = {
 		.name = "DLLC",
 		.description = "GPRS Logical Link Control Protocol (LLC)",
diff --git a/tests/sgsn/sgsn_test.c b/tests/sgsn/sgsn_test.c
index 0574620..63a7f3e 100644
--- a/tests/sgsn/sgsn_test.c
+++ b/tests/sgsn/sgsn_test.c
@@ -1620,11 +1620,6 @@
 		.description = "GPRS Packet Service",
 		.enabled = 1, .loglevel = LOGL_DEBUG,
 	},
-	[DNS] = {
-		.name = "DNS",
-		.description = "GPRS Network Service (NS)",
-		.enabled = 1, .loglevel = LOGL_INFO,
-	},
 	[DLLC] = {
 		.name = "DLLC",
 		.description = "GPRS Logical Link Control Protocol (LLC)",

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/23248
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia4723ab344ad6a1927029a2d5d0dda020266b39d
Gerrit-Change-Number: 23248
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210310/20e2c26e/attachment.htm>


More information about the gerrit-log mailing list