This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23243 ) Change subject: gprs_ns2_vty: Clarify VTY help string wording ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/23243/1/src/gb/gprs_ns2_vty.c File src/gb/gprs_ns2_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/23243/1/src/gb/gprs_ns2_vty.c@357 PS1, Line 357: "unique identifier for this bind (to reference from NS-VCs, NSEs, ...)\n" > Unique same as below. https://gerrit.osmocom.org/c/libosmocore/+/23243/1/src/gb/gprs_ns2_vty.c@402 PS1, Line 402: "unique identifier for this bind\n" > caps in first letter? there's unfortunately a lot of code in gprs_ns2 that uses lowercase. I'll clean this up in an overall patch once the actual work (SGSN-side SNS support) is merged. https://gerrit.osmocom.org/c/libosmocore/+/23243/1/src/gb/gprs_ns2_vty.c@603 PS1, Line 603: "Local IPv4 Address\n" "Local IPv6 Address\n" > IP_STR IPV6_STR My change is to introduce "Local" to the names. Your suggestion is to keep the existing wording but us a #define. I think the "local" adds value here... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7d70f8cc811c2f4aabf9fc00e4e612dfc4b031d3 Gerrit-Change-Number: 23243 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 05 Mar 2021 12:52:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210305/6c6bcd18/attachment.htm>