This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/23131 ) Change subject: trx_toolkit/data_msg.py: decorate abstract methods as such ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/23131/2/src/target/trx_toolkit/data_msg.py File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/c/osmocom-bb/+/23131/2/src/target/trx_toolkit/data_msg.py@160 PS2, Line 160: raise NotImplementedError fyi, since they are marked abstractmethod they shouldn't be callable because python wil ldetec tit at class instance construction, so this code will never be executed. Hence you can use "pass" in this line instead. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/23131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I27fdcfdabc2b5318ab3e958d2e5446e670fe9035 Gerrit-Change-Number: 23131 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 01 Mar 2021 10:20:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210301/c3273904/attachment.htm>