This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24776 ) Change subject: osmo-bts-trx: implement BCCH carrier power reduction mode ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/24776/4/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/24776/4/src/common/rsl.c@2217 PS4, Line 2217: if (c0->ts[7].bcch_power_red_db > 0) > why is this needed? isn't it already done by above loop? it's because ts[0] is not GSM_PCHAN_CCCH? Yeah, ts[0] can be either of GSM_PCHAN_CCCH, GSM_PCHAN_CCCH_SDCCH4, GSM_PCHAN_CCCH_SDCCH4_CBCH. I don't want to check them all in the loop, because combined combinations are only allowed on ts[0]. But I think I can simplify the code a bit and make it more readable, given that additional BCCH/CCCH can only be allocated on TS2, TS4, and TS6. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3dcee6e910ccc61c5c63c728db9ea04327e2fc98 Gerrit-Change-Number: 24776 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 29 Jun 2021 15:29:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210629/5472642c/attachment.htm>