Change in osmo-bts[master]: allow to configure multiple oml remote-ip addresses

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24513 )

Change subject: allow to configure multiple oml remote-ip addresses
......................................................................


Patch Set 5:

(14 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c 
File src/common/abis.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@66 
PS5, Line 66: 	ABIS_LINK_ST_CONN,
CONN means CONNECTED here? CONNECTING? Most probably needs to be changed to some of those, it's not clear at first sight.


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@67 
PS5, Line 67: 	ABIS_LINK_ST_FAIL,
state is FAILED right? FAIL it's more like an event or action.


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@87 
PS5, Line 87: static void abis_link_conn_action(struct osmo_fsm_inst *fi, uint32_t event, void *data)
we usually don't use "_action" suffix, only the name. Changing state name to something more meaningful may help here.


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@144 
PS5, Line 144: 		/* In some implementations the user may specify a BSC host via commandline switch. If this is the case
(doesn't look clear to me to take cmdline related specialties here, but OK)


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@148 
PS5, Line 148: 	} else if ((struct llist_head *)priv->bsc_oml_host != (struct llist_head *)&bts->bsc_oml_hosts.next) {
llist_first(&bts->bsc_oml_hosts)? Or do you actually mean the end of the list? isn't that "previous"?


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@149 
PS5, Line 149: 		/* Get a BSC host from the list and move the list heade one position forward. */
type: header


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@153 
PS5, Line 153: 	} else {
maybe moving this early termiantion above (if condition) would help making the function a bit less complex


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@163 
PS5, Line 163: 	osmo_get_macaddr(bts_dev_info.mac_addr, "eth0");
what is this? hardcoded eth0? this looks wrong


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@172 
PS5, Line 172: 	if (line) {
drop {}


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@176 
PS5, Line 176: 	priv->line_ctr++;
not sure what this is about


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@206 
PS5, Line 206: 			       .name = "CONN",
CONNECTING


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/abis.c@207 
PS5, Line 207: 			       .in_event_mask = 0 | S(ABIS_LINK_EV_SIGN_LINK_DOWN)
this 0| can be dropped


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/main.c 
File src/common/main.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/main.c@399 
PS5, Line 399: 	if (llist_count(&g_bts->bsc_oml_hosts) == 0) {
what about the cmdline oml ip I saw in the fsm which was outisde the llist?


https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24513/5/src/common/vty.c@536 
PS5, Line 536: {
iirc you are maintaining a pointer to the currently "connecting" remote ip. If you remove it through this VTY cmd, when the conn fails it will try to access the already freed pointer.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24513
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727
Gerrit-Change-Number: 24513
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Jun 2021 15:35:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210628/f2676e0d/attachment.htm>