This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24776 ) Change subject: osmo-bts-trx: implement BCCH carrier power reduction mode ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-bts/+/24776/1/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/24776/1/src/common/rsl.c@2212 PS1, Line 2212: ts->bcch_power_red_db = 2; > Aren't you overwriting this value upon next loop iteration in "ts->bcch_power_red_db = 0;" (line 220 […] Each loop iteration affects only one timeslot with index 'tn'. Here we just check if BCCH/CCCH follows (it can additionally be on TS2, TS4, and TS6) and limit the value to 2 dB if so. This is required by the specs. I'll add more references. https://gerrit.osmocom.org/c/osmo-bts/+/24776/1/src/common/rsl.c@3604 PS1, Line 3604: /* Osmocom specific extension for BCCH carrier power reduction */ > Some reference to spec here or above in the function would be helpful, specially since this seem to […] Ack https://gerrit.osmocom.org/c/osmo-bts/+/24776/1/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/24776/1/src/common/scheduler.c@1322 PS1, Line 1322: br->att = 0; > why is this needed? To ensure no attenuation on active channels, because this feature is for IDLE channels. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3dcee6e910ccc61c5c63c728db9ea04327e2fc98 Gerrit-Change-Number: 24776 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 28 Jun 2021 11:10:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210628/d9c4a54e/attachment.htm>