This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/24747 ) Change subject: pdch: Fix null MS access gprs_rlcmac_pdch::rcv_control_ack ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/24747/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/24747/1/src/pdch.cpp@316 PS1, Line 316: fn, tlli, trx_no(), ts_no); > maybe we can get rid of the ms variable completely (see below) if we just do: […] ms is used lots of times inside the if clause below, so it's not possible to do what you say. https://gerrit.osmocom.org/c/osmo-pcu/+/24747/1/src/pdch.cpp@336 PS1, Line 336: /* Gather MS from TBF, since it may be NULL or may have been merged during update_ms */ > maybe we can drop this if we use tbf->ms() below (nacc)? Actually I'll do it the other way, remove use of tbf->ms() below. I prefer having ms variable avaialble rather than getting it every time. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24747 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I666ed5d157f42e74956fa49fc9eea85d27e63d44 Gerrit-Change-Number: 24747 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Wed, 23 Jun 2021 11:44:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210623/74c1c5ec/attachment.htm>