This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24513 ) Change subject: allow to configure multiple oml remote-ip addresses ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/main.c File src/common/main.c: https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/main.c@402 PS1, Line 402: LOGP > I think it's fine changing this since anyway he's changing lots of lines around this one. Its probably better to go around and replace all fprintf() to LOGP() first - there are a lot of them and it really makes sense to use LOGP() for all of them. https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/main.c@419 PS1, Line 419: BSC > Ack I think only A-bis is best here. https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/vty.c File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/vty.c@514 PS1, Line 514: /* Silently stop when the address is already in the list */ > Any reason to tolerate duplicate entries? There may be copy-paste errors in the config file, and her […] Done https://gerrit.osmocom.org/c/osmo-bts/+/24513/1/src/common/vty.c@543 PS1, Line 543: if (bsc_oml_host_del) { > Same here, removing a non-existing entry should be considered an error. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I205f68a3a7f35fee4c38a7cfba2b014237df2727 Gerrit-Change-Number: 24513 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 17 Jun 2021 10:43:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210617/00b6a3cf/attachment.htm>