This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/24682 ) Change subject: gprs_ns2: use llist_add_tail to keep order ...................................................................... gprs_ns2: use llist_add_tail to keep order When configuring multiple NSE/BINDs the order of the configuration should be keeped. Change-Id: Ibbc03f0780b49543b5bd97ee059f11cfd6c2a126 --- M src/gb/gprs_ns2.c M src/gb/gprs_ns2_vty.c 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/24682/1 diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c index 618d55e..3bf31a3 100644 --- a/src/gb/gprs_ns2.c +++ b/src/gb/gprs_ns2.c @@ -609,8 +609,8 @@ rate_ctr_group_set_name(nsvc->ctrg, id); osmo_stat_item_group_set_name(nsvc->statg, id); - llist_add(&nsvc->list, &nse->nsvc); - llist_add(&nsvc->blist, &bind->nsvc); + llist_add_tail(&nsvc->list, &nse->nsvc); + llist_add_tail(&nsvc->blist, &bind->nsvc); ns2_nse_update_mtu(nse); return nsvc; @@ -809,7 +809,7 @@ nse->nsi = nsi; nse->first = true; nse->mtu = 0; - llist_add(&nse->list, &nsi->nse); + llist_add_tail(&nse->list, &nsi->nse); INIT_LLIST_HEAD(&nse->nsvc); return nse; @@ -1633,7 +1633,7 @@ bind->sns_data_weight = 1; bind->nsi = nsi; INIT_LLIST_HEAD(&bind->nsvc); - llist_add(&bind->list, &nsi->binding); + llist_add_tail(&bind->list, &nsi->binding); nsi->bind_rate_ctr_idx++; diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c index 2777641..705b60e 100644 --- a/src/gb/gprs_ns2_vty.c +++ b/src/gb/gprs_ns2_vty.c @@ -141,7 +141,7 @@ vbind->ip_sns_sig_weight = 1; vbind->ip_sns_data_weight = 1; - llist_add(&vbind->list, &binds); + llist_add_tail(&vbind->list, &binds); return vbind; } @@ -172,7 +172,7 @@ vnse->nsei = nsei; INIT_LLIST_HEAD(&vnse->binds); - llist_add(&vnse->list, &nses); + llist_add_tail(&vnse->list, &nses); return vnse; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc03f0780b49543b5bd97ee059f11cfd6c2a126 Gerrit-Change-Number: 24682 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210615/90e29c24/attachment.htm>