This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24544 ) Change subject: osmo_select_shutdown_request(): allow finishing pending writes on SIGTERM ...................................................................... Patch Set 3: (1 comment) lgtm, except for the question about the conditional osmo_timers_update() https://gerrit.osmocom.org/c/libosmocore/+/24544/3/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/24544/3/src/select.c@387 PS3, Line 387: if (!_osmo_select_shutdown_requested) > I'm not sure if this is a good idea, it could affect assumptions on the application, leading to diff […] I'd also say it's an over-optimization. do we care if osmo_timers_update() is called unconditionally here? What would be the danger of keeping the current behavior? Maybe pespin and I don't get the rationale. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib94d4316924103459577087c2214188679db2227 Gerrit-Change-Number: 24544 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jun 2021 16:32:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210615/574c5090/attachment.htm>