Change in osmo-bsc[master]: handover_ctrl: add control interface for handover settings

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24600 )

Change subject: handover_ctrl: add control interface for handover settings
......................................................................


Patch Set 1:

(7 comments)

Thanks for reviewing this.

I have fixed the easy parts. Unfortunately I did not notice the handover commands on network level. I will have another look at this tomorrow.

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/doc/manuals/chapters/control.adoc 
File doc/manuals/chapters/control.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/doc/manuals/chapters/control.adoc@41 
PS1, Line 41: |handover_ho_active|RW|No|"0","1","default"|Enable/disable handover.
> be aware that (almost?) all handover, handover1 and handover2 vty commands exist on the 'network' no […]
I did not notice that. This probably means that I have dig a bit deeper. I only noticed the handover commands on network level.


https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c 
File src/osmo-bsc/handover_ctrl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c@33 
PS1, Line 33: bool verify_vty_cmd_arg(void *ctx, const char *range, const char *value)
> i understand: the macros that were invented for VTY are now used for CTRL. […]
The function cmd_match is a bit strange, I could not make it work, but I from the code I can see that it uses cmd_range_match() to match the range. This works fine for me. However, even in cmd_match, I did not see any code that matches the choice strings ("test1|test2|test3").


https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c@88 
PS1, Line 88: 		cmd->reply = talloc_asprintf(cmd, VTY_WRITE_FMT, VTY_WRITE_CONV(val)); \
> the HO_CFG_ONE_MEMBER() has arguments called VTY_WRITE_FMT and VTY_WRITE_CONV. […]
I think putting a comment might sufficient.


https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c@98 
PS1, Line 98: 	if (strcmp(cmd->value, "default") == 0)	\
> (before '\' should be space, not tab)
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c@114 
PS1, Line 114: #undef HO_CFG_ONE_MEMBER
> please insert spacing here. […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c@161 
PS1, Line 161: 	rc |= ctrl_cmd_install(CTRL_NODE_ROOT, &cmd_##NAME);\
> (usually no '\' on last line; if you want to keep it maybe add a space before it)
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c@163 
PS1, Line 163: HO_CFG_ALL_MEMBERS
> @pespin i don't understand what you mean […]
Probably we should list the manually defined commands first and then proceed with the auto generated commands.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24600
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I12f143906818fd6b16e8783157cbb1eb51e49ffc
Gerrit-Change-Number: 24600
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Assignee: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Jun 2021 20:15:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210614/8ba0aa75/attachment.htm>