This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24640 ) Change subject: ctrl: Support recovering from short write ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/24640/1/src/ctrl/control_if.c File src/ctrl/control_if.c: https://gerrit.osmocom.org/c/libosmocore/+/24640/1/src/ctrl/control_if.c@494 PS1, Line 494: return 0; > I guess it should be […] "if (rc <= 0)" no, because the rc==0 case is already checked above, so it can't be 0. "returning 0 here?" I'm keeping old behavior here, which to me is fine, since the caller of this callback actually does stuff with error conditions, so returning 0 is fine, as in "do nothing, drop the message and continue". -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6cbc7ec6ae6832e61cddf4402332ba09b142a7d4 Gerrit-Change-Number: 24640 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jun 2021 15:27:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/95c837b7/attachment.htm>