This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24429 ) Change subject: rsl_lchan_lookup(): add comment explaining ts_is_capable_of_pchan() ...................................................................... rsl_lchan_lookup(): add comment explaining ts_is_capable_of_pchan() Change-Id: Ie3699db496cfb690ac9302ccd177cdd77dc57ebb --- M src/osmo-bsc/bts_trx.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/bts_trx.c b/src/osmo-bsc/bts_trx.c index 8d47ba5..3f73f7f 100644 --- a/src/osmo-bsc/bts_trx.c +++ b/src/osmo-bsc/bts_trx.c @@ -156,6 +156,10 @@ if (rc) *rc = -EINVAL; + /* Why call ts_is_capable_of_pchan() here? Dynamic timeslots may receive RSL Channel Activation ACK on a + * timeslot that is in transition between pchan modes. That ACK actually confirms the pchan switch, so instead + * of checking the current pchan mode, we must allow any pchans that a dyn TS is capable of. */ + switch (cbits) { case ABIS_RSL_CHAN_NR_CBITS_Bm_ACCHs: lch_idx = 0; /* TCH/F */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie3699db496cfb690ac9302ccd177cdd77dc57ebb Gerrit-Change-Number: 24429 Gerrit-PatchSet: 16 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/7fc5bb11/attachment.htm>