This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24613 ) Change subject: osmo-bts-trx: report interference levels to the upper layers ...................................................................... Patch Set 1: Code-Review+1 (2 comments) looks good to me, as suggested by pespin I would get rid of the >= operator. https://gerrit.osmocom.org/c/osmo-bts/+/24613/1/include/osmo-bts/scheduler.h File include/osmo-bts/scheduler.h: https://gerrit.osmocom.org/c/osmo-bts/+/24613/1/include/osmo-bts/scheduler.h@138 PS1, Line 138: struct l1sched_meas_set buf[8]; /* up to 8 entries */ Maybe replacing the 8 with a define constant makes sense? https://gerrit.osmocom.org/c/osmo-bts/+/24613/1/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/24613/1/src/common/scheduler.c@1494 PS1, Line 1494: if (bi->chan >= TRXC_TCHF) > so what about moving it to a function helper and having here chan_is_dcch()? Doing the comparison with a >= sounds a bit dangerous since it relies on the order of the items in that enum definition. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4686448e42a40df56c1d27a14fd0a4d43fd144a5 Gerrit-Change-Number: 24613 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 09 Jun 2021 10:06:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210609/a5819e38/attachment.htm>