This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24624 ) Change subject: allow mode modify when RTP stream is active ...................................................................... allow mode modify when RTP stream is active Get rid of this artificial barrier, because Modify with active voice stream is supported since commit "lchan and assignment FSMs: make Channel Mode Modify more sane" d5cb0eb8fda3ade89c7b2e23a626b68dfda96f46 I4986844f839b1c9672c61d916eb3d33d0042d747 Change-Id: I25f4a881fa32a07f97d7d6e6b812f8afc699d951 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index c06735f..ded4129 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -1111,15 +1111,6 @@ return; case LCHAN_EV_REQUEST_MODE_MODIFY: - - /* FIXME: Add missing implementation to handle an already existing RTP voice stream on MODE MODIFY. - * there may be transitions from VOICE to SIGNALLING and also from VOICE to VOICE with a different - * codec. */ - if (lchan->fi_rtp) { - lchan_fail("MODE MODIFY not implemented when RTP voice stream is already active (VOICE => SIGNALLING, VOICE/CODEC_A => VOICE/CODEC_B)\n"); - return; - } - modif_info = data; lchan->modify.info = *modif_info; lchan->modify.concluded = false; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I25f4a881fa32a07f97d7d6e6b812f8afc699d951 Gerrit-Change-Number: 24624 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210609/303966a4/attachment.htm>