This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24527 ) Change subject: measurement: remove over-defensive checks in is_meas_complete() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/24527/1/src/common/measurement.c File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/24527/1/src/common/measurement.c@a257 PS1, Line 257: but what's the point of removing these checks? optimization?!? ts_pchan() mostly returns ts->pchan, who knows what's in there. Looks to me like someone wanted to make sure to have a valid ts pointer. i'd just keep these, maybe there was a good reason once that we don't see, and these checks have exactly no drawback. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6d20d7cba49cc8b6d1dc2192598ca372b7d2c5bf Gerrit-Change-Number: 24527 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Sat, 05 Jun 2021 20:39:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210605/7ebd17fb/attachment.htm>