Change in osmo-bts[2021q1]: trx_sched_is_sacch_fn(): fix handling of dynamic timeslots

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Jun 5 14:54:04 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24568 )

Change subject: trx_sched_is_sacch_fn(): fix handling of dynamic timeslots
......................................................................

trx_sched_is_sacch_fn(): fix handling of dynamic timeslots

There is no GSM_PCHAN_TCH_F{_TCH_H}_PDCH in trx_sched_multiframes[],
so find_sched_mframe_idx() would always return -1 for these.  Fix
this by using ts_pchan(), which returns currently active pchan type.

Change-Id: Ia5e337e897b595e7de6e504664c969b583cc02a1
---
M src/common/scheduler_mframe.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/common/scheduler_mframe.c b/src/common/scheduler_mframe.c
index b969407..f6476ec 100644
--- a/src/common/scheduler_mframe.c
+++ b/src/common/scheduler_mframe.c
@@ -1007,7 +1007,7 @@
 	const struct trx_sched_frame *frame;
 	enum trx_chan_type ch_type;
 
-	i = find_sched_mframe_idx(ts->pchan, ts->nr);
+	i = find_sched_mframe_idx(ts_pchan(ts), ts->nr);
 	if (i < 0)
 		return -EINVAL;
 	sched = &trx_sched_multiframes[i];

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24568
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: 2021q1
Gerrit-Change-Id: Ia5e337e897b595e7de6e504664c969b583cc02a1
Gerrit-Change-Number: 24568
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210605/a1e40c01/attachment.htm>


More information about the gerrit-log mailing list