This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24524 ) Change subject: RSL chan_nr: replace OSMO_ASSERT with error handling ...................................................................... Patch Set 3: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/24524/3/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24524/3/src/osmo-bsc/abis_rsl.c@292 PS3, Line 292: maybe cast to (uint8_t) to mark that this is cast (chan_nr was uint8_t before) ? https://gerrit.osmocom.org/c/osmo-bsc/+/24524/3/src/osmo-bsc/osmo_bsc_lcls.c File src/osmo-bsc/osmo_bsc_lcls.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24524/3/src/osmo-bsc/osmo_bsc_lcls.c@253 PS3, Line 253: msg = rsl_make_ipacc_mdcx(lchan, ip, port); Isn't that unrelated? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I71ed6437c403a3f9336e17a94b4948fca295d853 Gerrit-Change-Number: 24524 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 03 Jun 2021 13:27:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210603/4256a3cb/attachment.htm>