This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/24537 ) Change subject: firmware: octsimtest: use TRACE_* macros instead of direct printf ...................................................................... firmware: octsimtest: use TRACE_* macros instead of direct printf Change-Id: I41864bc2f64905a4f2ccb50769b1840e8a490c76 --- M firmware/libboard/octsimtest/source/mcp23017.c M firmware/libboard/octsimtest/source/mux.c 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/libboard/octsimtest/source/mcp23017.c b/firmware/libboard/octsimtest/source/mcp23017.c index bc6bd49..959f2c6 100644 --- a/firmware/libboard/octsimtest/source/mcp23017.c +++ b/firmware/libboard/octsimtest/source/mcp23017.c @@ -94,7 +94,7 @@ int mcp23017_init(uint8_t slave, uint8_t iodira, uint8_t iodirb) { - printf("mcp23017_init\n\r"); + TRACE_DEBUG("mcp23017_init\n\r"); // all gpio input if (mcp23017_write_byte(slave, MCP23017_IODIRA, iodira)) @@ -105,11 +105,11 @@ if (mcp23017_write_byte(slave, MCP23017_IOCONA, 0x20)) //disable SEQOP (autoinc addressing) goto out_err; - printf("mcp23017 found\n\r"); + TRACE_DEBUG("mcp23017 found\n\r"); return 0; out_err: - printf("mcp23017 NOT found!\n\r"); + TRACE_WARNING("mcp23017 NOT found!\n\r"); return -1; } diff --git a/firmware/libboard/octsimtest/source/mux.c b/firmware/libboard/octsimtest/source/mux.c index 54c6cb6..8800ba2 100644 --- a/firmware/libboard/octsimtest/source/mux.c +++ b/firmware/libboard/octsimtest/source/mux.c @@ -54,7 +54,7 @@ /* set the slot selection mux */ int mux_set_slot(uint8_t s) { - printf("%s(%u)\r\n", __func__, s); + TRACE_INFO("%s(%u)\r\n", __func__, s); if (s > 7) return -EINVAL; @@ -90,7 +90,7 @@ /* set the frequency divider mux */ void mux_set_freq(uint8_t s) { - printf("%s(%u)\r\n", __func__, s); + TRACE_INFO("%s(%u)\r\n", __func__, s); /* no need for 'break before make' here, this would also affect * the SIM card I/O signals which we don't want to disturb */ -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I41864bc2f64905a4f2ccb50769b1840e8a490c76 Gerrit-Change-Number: 24537 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210603/f7c1714f/attachment.htm>