This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25105 ) Change subject: tbf_dl: Clarify requirements for DL ACK/NACK ...................................................................... Patch Set 1: Code-Review+1 (2 comments) just some nitpicks https://gerrit.osmocom.org/c/osmo-pcu/+/25105/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/25105/1//COMMIT_MSG@15 PS1, Line 15: the code. (seems like two logical changes at once... but given that the total patch size is still small I guess it's fine here) https://gerrit.osmocom.org/c/osmo-pcu/+/25105/1/src/tbf_dl.cpp File src/tbf_dl.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25105/1/src/tbf_dl.cpp@1214 PS1, Line 1214: * when last polled DL ACK/NACK was lost. */ (it would be nicer to describe the conditions in the same order as below.) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib0e9b9547f5292b95064bab2dc182fdf659f0518 Gerrit-Change-Number: 25105 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Fri, 30 Jul 2021 13:06:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210730/a166635d/attachment.htm>