Change in osmo-ci[master]: lint: ignore LONG_LONE

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Thu Jul 29 17:24:24 UTC 2021


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/25107 )


Change subject: lint: ignore LONG_LONE
......................................................................

lint: ignore LONG_LONE

With recent code reviews I've realized that in Osmocom we do often use
more than 120 characters per line for various reasons. So adjust the
linter to not fail anymore if that is the case.

Related: https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h#32
Related: https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/src/libmsc/msc_a.c#125
Related: OS#5087
Change-Id: I88fd86ac550fddb3017aeceb647c3d9e75367372
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/07/25107/1

diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh
index e88688a..abeed56 100755
--- a/lint/checkpatch/checkpatch_osmo.sh
+++ b/lint/checkpatch/checkpatch_osmo.sh
@@ -23,6 +23,7 @@
 # * INITIALISED_STATIC: we use this, see also http://lkml.iu.edu/hypermail/linux/kernel/0808.1/2235.html
 # * LINE_CONTINUATIONS: false positives
 # * LINE_SPACING: we don't always put a blank line after declarations
+# * LONG_LINE: should be 120 chars, but exceptions are done often so don't fail here
 # * PREFER_DEFINED_ATTRIBUTE_MACRO: macros like __packed not defined in libosmocore
 # * PREFER_FALLTHROUGH: pseudo keyword macro "fallthrough" is not defined in libosmocore
 # * REPEATED_WORD: false positives in doxygen descriptions (e.g. '\param[in] data Data passed through...')
@@ -50,6 +51,7 @@
 	--ignore INITIALISED_STATIC \
 	--ignore LINE_CONTINUATIONS \
 	--ignore LINE_SPACING \
+	--ignore LONG_LINE \
 	--ignore PREFER_DEFINED_ATTRIBUTE_MACRO \
 	--ignore PREFER_FALLTHROUGH \
 	--ignore REPEATED_WORD \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25107
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I88fd86ac550fddb3017aeceb647c3d9e75367372
Gerrit-Change-Number: 25107
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/3f26751f/attachment.htm>


More information about the gerrit-log mailing list