This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25056 ) Change subject: Replace ul_ass_state with osmocom FSM ...................................................................... Patch Set 4: (7 comments) The only problem I see is having two FSMs with the same ID seems strange, otherwise just some cosmetic comments, rest looks good! https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf.cpp File src/tbf.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf.cpp@a767 PS4, Line 767: s X2000, why was this removed? (maybe it makes sense to do this in a separate commit and explain it there?) https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf.cpp@967 PS4, Line 967: osmo_fsm_inst_update_id(tbf->ul_ass_fsm.fi, buf); Why give two separate FSMs the same ID, wouldn't it be better to add some kind of suffix that differentiates them? https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h File src/tbf_ul_ass_fsm.h: https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@32 PS4, Line 32: TBF_UL_ASS_EV_CREATE_RLCMAC_MSG, /* Scheduler wants to gen+Tx the Ass (rej): data=tbf_ul_ass_ev_create_rlcmac_msg_ctx */ (line length) https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@50 PS4, Line 50: assignment_fsm_timeouts where is assignment_fsm_timeouts defined? (I can't find it, maybe this has been renamed? it's also used two more times in other comments) https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@52 PS4, Line 52: fi fi is passed as parameter, so this should be "the_pcu"? https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h@62 PS4, Line 62: MS_ANR_EV_CREATE_RLCMAC_MSG can't find this, do you mean TBF_UL_ASS_EV_CREATE_RLCMAC_MSG? https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.c File src/tbf_ul_ass_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.c@306 PS4, Line 306: bool tbf_ul_ass_rts(const struct gprs_rlcmac_tbf* tbf) assuming rts means.... ready to send? would be good to add it as comment (unless this is a very common abbreviation that I just didn't see much yet) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id414eafe9c04a9a8759c6fb1a483bf2ee093a4d2 Gerrit-Change-Number: 25056 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Thu, 29 Jul 2021 07:18:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/a130e9d2/attachment.htm>