Change in osmo-bsc[master]: vty: improve err msg for invalid subslot nr

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jul 27 07:34:07 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25040 )

Change subject: vty: improve err msg for invalid subslot nr
......................................................................

vty: improve err msg for invalid subslot nr

Change-Id: I2f649bd2d8d9f217c22b62d2842e1e4fa101ba11
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index b0fe8bf..6d10426 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -1728,7 +1728,8 @@
 		return CMD_WARNING;
 
 	if (ss_nr >= ts->max_primary_lchans) {
-		vty_out(vty, "Invalid sub-slot number for this timeslot type%s", VTY_NEWLINE);
+		vty_out(vty, "Invalid sub-slot number %d for this timeslot type: %s (%u)%s", ss_nr,
+			gsm_pchan_name(ts->pchan_on_init), ts->max_primary_lchans, VTY_NEWLINE);
 		return CMD_WARNING;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25040
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2f649bd2d8d9f217c22b62d2842e1e4fa101ba11
Gerrit-Change-Number: 25040
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210727/95a9f6b6/attachment.htm>


More information about the gerrit-log mailing list